Docker-in-docker: Updates docker-init with "pkill" - #711
Merged
Samruddhi Khandale (samruddhikhandale) merged 4 commits intoSep 29, 2023
Conversation
Samruddhi Khandale (samruddhikhandale)
marked this pull request as ready for review
September 29, 2023 18:38
Samruddhi Khandale (samruddhikhandale)
requested a review
from a team
as a code owner
September 29, 2023 18:38
joshspicer
approved these changes
Sep 29, 2023
joshspicer
left a comment
joshspicer
left a comment
Member
There was a problem hiding this comment.
looks very reasonable to me 👍
Samruddhi Khandale (samruddhikhandale)
deleted the
samruddhikhandale/dnd-pkill
branch
September 29, 2023 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : devcontainers/images#729
When the universal image is built with latest
docker-in-dockerFeature, it fails to start docker daemon ascontainerddoes not start (Reported in #671 (comment)) .The image is trying to retry the docker daemon startup, but ascontainerd(or/anddockerd)is not in a good state before, it fails to restart causingdocker psto fail.We do have these commands ^ but it simply removes the PID files, does not stop/clean the dockerd and containerd daemons
🧪 Tested these PR changes with
universal:dev@sha256:b7a147f15c61f02b8220d1719431f205f65e48267ffed93e0b9c642c14cf956aimage,docker psis successful.